Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): the ESC keydown event not handled correctly #5973

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

hsuanxyz
Copy link
Member

close #5965

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5965

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 26, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #5973 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5973      +/-   ##
==========================================
+ Coverage   89.96%   89.99%   +0.02%     
==========================================
  Files         465      465              
  Lines       14047    14049       +2     
  Branches     2311     2312       +1     
==========================================
+ Hits        12637    12643       +6     
- Misses        859      860       +1     
+ Partials      551      546       -5     
Impacted Files Coverage Δ
components/select/select.component.ts 87.54% <100.00%> (+0.42%) ⬆️
components/table/src/table/tbody.component.ts 85.71% <0.00%> (-14.29%) ⬇️
components/table/src/table/tr-measure.component.ts 86.36% <0.00%> (-13.64%) ⬇️
components/time-picker/time-holder.ts 95.78% <0.00%> (+1.05%) ⬆️
components/tabs/tab-nav-bar.component.ts 83.03% <0.00%> (+1.41%) ⬆️
components/table/src/table-style.service.ts 96.55% <0.00%> (+1.72%) ⬆️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2125f9f...cd24249. Read the comment docs.

@hsuanxyz hsuanxyz merged commit d898cce into NG-ZORRO:master Oct 26, 2020
@hsuanxyz hsuanxyz deleted the fix/select-esc branch October 26, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escape key to close a opened nz-select menu will close the whole drawer
1 participant