-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove custom webpack #8553
build: remove custom webpack #8553
Conversation
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8553 +/- ##
==========================================
- Coverage 91.57% 91.56% -0.02%
==========================================
Files 532 532
Lines 18334 18337 +3
Branches 2802 2803 +1
==========================================
Hits 16790 16790
- Misses 1226 1229 +3
Partials 318 318 ☔ View full report in Codecov by Sentry. |
5d0c198
to
209f749
Compare
components/style/testing.less
Outdated
// This file is only used to set the @root-entry-name variable in a test environment. | ||
|
||
@import './default.less'; | ||
// @import './variable.less'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
当测试中需要导入样式时,必须首先导入该样式文件。该文件用于在测试中设置 @root-entry-name 变量。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
最后一行可以删掉吧👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以了
be350b9
to
b577aaa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previous pr #8552 was merged, please rebase
c6fe4bd
to
0c92905
Compare
Done. |
0c92905
to
4e63d7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
此 PR 基于 #8552。
通过此 PR,ZORRO 不再自定义 webpack 配置,这有利于更快的跟随 Angular 的版本更新,不必等待 @angular-builders/custom-webpack 包更新。
Does this PR introduce a breaking change?
Other information