Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove custom webpack #8553

Merged
merged 1 commit into from
May 31, 2024

Conversation

HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented May 27, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

此 PR 基于 #8552

通过此 PR,ZORRO 不再自定义 webpack 配置,这有利于更快的跟随 Angular 的版本更新,不必等待 @angular-builders/custom-webpack 包更新。

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

zorro-bot bot commented May 27, 2024

This preview will be available after the AzureCI is passed.

@HyperLife1119 HyperLife1119 changed the title build: remove-custom-webpack build: remove custom webpack May 27, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.56%. Comparing base (0be6178) to head (4e63d7c).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8553      +/-   ##
==========================================
- Coverage   91.57%   91.56%   -0.02%     
==========================================
  Files         532      532              
  Lines       18334    18337       +3     
  Branches     2802     2803       +1     
==========================================
  Hits        16790    16790              
- Misses       1226     1229       +3     
  Partials      318      318              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 1 to 4
// This file is only used to set the @root-entry-name variable in a test environment.

@import './default.less';
// @import './variable.less';
Copy link
Collaborator Author

@HyperLife1119 HyperLife1119 May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当测试中需要导入样式时,必须首先导入该样式文件。该文件用于在测试中设置 @root-entry-name 变量。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最后一行可以删掉吧👀

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以了

@HyperLife1119 HyperLife1119 force-pushed the build/remove-custom-webpack branch 2 times, most recently from be350b9 to b577aaa Compare May 28, 2024 17:37
Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previous pr #8552 was merged, please rebase

@HyperLife1119 HyperLife1119 force-pushed the build/remove-custom-webpack branch 2 times, most recently from c6fe4bd to 0c92905 Compare May 30, 2024 06:15
@HyperLife1119
Copy link
Collaborator Author

previous pr #8552 was merged, please rebase

Done.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit 710e20e into NG-ZORRO:master May 31, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants