Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce loop bounds on hi-frequency radiation history updates #758

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

rgknox
Copy link
Contributor

@rgknox rgknox commented Jun 24, 2021

Description:

Changed loop bounds in history writing to use actual rather than maximum canopy layers and leaf layers.

fixes: #755

Collaborators:

Expectation of Answer Changes:

Should be B4B

Checklist:

  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

TBD

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@rgknox
Copy link
Contributor Author

rgknox commented Jun 25, 2021

Note: I did check through the call sequence, particularly during restarts, to make sure that cpatch%ncl_p and
cpatch%ncan(ican,ipft) had been updated and set before this call.
Also, in earlier tests, this gave me b4b answers with the base.

Copy link
Contributor

@ckoven ckoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @rgknox!

@rgknox
Copy link
Contributor Author

rgknox commented Oct 11, 2021

Tests pass, b4b:
/glade/scratch/rgknox/tests_1010-151719ch

@rgknox rgknox merged commit 23705ed into NGEET:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reduce loop iterations in history hifreq
3 participants