Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip unresolvable dns entry on policy creation #86

Closed
bluecraank opened this issue Jan 23, 2024 · 2 comments
Closed

Skip unresolvable dns entry on policy creation #86

bluecraank opened this issue Jan 23, 2024 · 2 comments
Assignees
@NHAS
Labels
bug Something isn't working enhancement New feature or request needs testing (on unstable) If the feature exists, but isnt yet released

Comments

@bluecraank
Copy link
Contributor

bluecraank commented Jan 23, 2024 •
edited
Loading

  • Instead of exiting and dont create any policy, skip unresolvable dns entry

If the user activates the wireguard tunnel and tries to open totp page, it does not work because there are no policies for the user created. This occurs if one of the rules does have a unresolvable dns entry.

Maybe its possible to skip this entry for the user policy and go ahead with the other, so at least totp page works

  • WAG Version: Wag v7.3.2-26-g8a7c225 (build with unstable)
  • Kernel: 6.1.0-13-amd64
@NHAS NHAS added bug Something isn't working enhancement New feature or request labels Jan 23, 2024
@NHAS
Copy link
Owner

NHAS commented Jan 23, 2024

Yep I agree this would be a sane thing to do. At the moment in the middle of a huge rewrite in prep for making wag highly available.

@NHAS NHAS self-assigned this Jan 24, 2024
NHAS added a commit that referenced this issue Jan 24, 2024
@NHAS
#86 make rule parsing hitting one invalid rule not kill entire rule a…
99a85df 
…pplication, add validator to data.SetAcl
@NHAS
Copy link
Owner

NHAS commented Jan 24, 2024

This exists on unstable. However I wouldnt recommend using unstable in any sort of production environment at the moment.

@NHAS NHAS added the needs testing (on unstable) If the feature exists, but isnt yet released label Jan 25, 2024
@krambrock krambrock mentioned this issue Feb 27, 2024
Closed
@NHAS NHAS closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NHAS NHAS

Labels
bug Something isn't working enhancement New feature or request needs testing (on unstable) If the feature exists, but isnt yet released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NHAS @bluecraank