Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ementas service with Pulumi #64

Merged
merged 45 commits into from
Aug 8, 2024
Merged

feat: add ementas service with Pulumi #64

merged 45 commits into from
Aug 8, 2024

Conversation

limwa
Copy link
Member

@limwa limwa commented Jun 25, 2024 •
edited
Loading

Closes #35.
Closes #47.

This PR deploys the NIAEFEUP/nimentas-sasup service using Pulumi.

Also contains a small change to services/cert-manager/deploy-dev.sh due to some issues in starting the dev cluster.

LuisDuarte1
LuisDuarte1 requested changes Jun 25, 2024
View reviewed changes
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, Pulumi seems great and might give us the power to simplify certain types of deployments :)

I haven't tested it yet, but just by reviewing the code I found some concerns:

services/pulumi/crds.yaml Outdated Show resolved Hide resolved
services/pulumi/Pulumi.prod.yaml Outdated Show resolved Hide resolved
services/pulumi/services/ementas/index.ts Outdated Show resolved Hide resolved
@limwa
Copy link
Member Author

limwa commented Jul 4, 2024 •
edited
Loading

  • add a method to specify dependencies for the mdbc resource ❌
  • add check for yq-go
  • add eslint and prettier
  • fix typo
  • separate reusable logic wherever possible
  • make mdbc use longhorn
  • add actions to check eslint and prettier

LuisDuarte1
LuisDuarte1 reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the way that clustersecret crds are created because clustersecret.io has probably expired :(
zakkg3/ClusterSecret#138

@limwa limwa marked this pull request as ready for review July 16, 2024 23:11
@limwa limwa requested review from LuisDuarte1 and a team July 16, 2024 23:12
LuisDuarte1
LuisDuarte1 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, congrats 🎉! Please open a separate issue to address proper partial deployments, because it's really useful for development.

@limwa limwa requested a review from LuisDuarte1 August 8, 2024 20:58
@limwa limwa requested a review from LuisDuarte1 August 8, 2024 22:25
@limwa limwa merged commit 059347c into main Aug 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuisDuarte1 LuisDuarte1 Awaiting requested review from LuisDuarte1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy ementas website Investigate Pulumi for defining k8s manifests
2 participants
@limwa @LuisDuarte1