-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use webpack for the build step #165
Conversation
Co-authored-by: Luís Duarte <luis.duarte.2003.13@hotmail.com>
Could you write the new script (corepack enable) before yarn install in the README file? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I make one change, it compiles, but keep repeating the compilation even If I don't touch the code source. Any idea of what may be?
The problem I commented before is now solved! The only problem here is the WebpackShellPluginNext scripts, which don't run when new changes are saved. However the CopyPlugin works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like Windows will still be a problem regarding watch scripts. :( However this is already a big improvement for the developer experience! Good job all 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ 🛫
Closes #164.
This PR migrates the build step away from the current
build-script.js
and uses webpack instead. It's quite inspired by the config at Refined Github, but adapted to our specific needs.This also migrates our project to corepack and yarn modern, so developers must run
corepack enable
before runningyarn install
.