Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current Account #53

Merged
merged 15 commits into from
Jun 21, 2023
Merged

Current Account #53

merged 15 commits into from
Jun 21, 2023

Conversation

thePeras
Copy link
Member

@thePeras thePeras commented Mar 15, 2023 •
edited
Loading

Closes #29

Screenshot 2023-04-03 at 17 28 51 Screenshot 2023-04-03 at 17 28 59 Screenshot 2023-04-03 at 17 29 07

@thePeras
Copy link
Member Author

thePeras commented Apr 3, 2023

This PR reverses all the dates of the website. Ex: 2023-03-23 to 23-03-2023
Because of this, the sort function executed when clicking at date header is not working property.

@thePeras thePeras marked this pull request as ready for review April 3, 2023 16:30
@thePeras thePeras mentioned this pull request Apr 3, 2023
Closed
ttoino
ttoino reviewed Jun 1, 2023
View reviewed changes
Copy link
Member

@ttoino ttoino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page looks good overall, but I'm getting this error in the console and for some reason, none of the icons are getting changed

image

The error is in line 133 of initialize.js

content-scripts/src/modules/initialize.js Outdated Show resolved Hide resolved
@thePeras
Copy link
Member Author

initialize.js

I can't reproduce, but It's a good idea to checks if there are tabs

@thePeras thePeras requested a review from ttoino June 10, 2023 14:11
ttoino
ttoino requested changes Jun 12, 2023
View reviewed changes
Copy link
Member

@ttoino ttoino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting an error, it seems to be caused by me having different tabs than you do

image
image

@thePeras thePeras requested a review from ttoino June 18, 2023 14:32
ttoino
ttoino approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@ttoino ttoino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be working now, good job!

@ttoino ttoino merged commit ea853bb into main Jun 21, 2023
@ttoino ttoino deleted the page/current-account branch June 21, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttoino ttoino ttoino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign "Conta Corrente" Page
2 participants
@thePeras @ttoino