Made redis url be constructed from environment variables and hostname not bounded to repository folder's name #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaspalma
changed the title
tomaspalma
requested review from
Process-ing,
thePeras,
Wallen-Ribeiro and
diogotvf7
thePeras
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82
.env.devfile template, so they are not hardcodeddocker-compose.yamlfile was changed so that therediscontainer has acontainer_nameinstead of its name being automatically built bydockerastts-be-redis_service-1which weren't allowing thebackendto be ran from a folder with a name different thantts-beREADMEwith steps to create an actual.envfile from the.env.devone, as well as added the information that we are able to accessphpmyadminas well as the necessary development credentials.This should also make it easier to deploy it correctly.