Feature/hash check endpoint #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaspalma
requested changes
Aug 13, 2024
jose-carlos-sousa
force-pushed
the
feature/hashCheckEndpoint
branch
2 times, most recently
from
d788cff
to
e5a3299
Compare
jose-carlos-sousa
force-pushed
the
feature/hashCheckEndpoint
branch
from
e5a3299
to
10953f7
Compare
tomaspalma
requested changes
Aug 13, 2024
tomaspalma
reviewed
Aug 13, 2024
jose-carlos-sousa
force-pushed
the
feature/hashCheckEndpoint
branch
from
3e4ca77
to
9294c4a
Compare
jose-carlos-sousa
force-pushed
the
feature/hashCheckEndpoint
branch
2 times, most recently
from
7c528a5
to
45dbb7b
Compare
tomaspalma
reviewed
Aug 15, 2024
django/university/urls.py
Outdated
| @@ -9,6 +9,7 @@ | |||
| path('course_unit/<int:course_unit_id>/', views.course_unit_by_id), | |||
| path('class/<int:course_unit_id>/', views.classes), | |||
| path('professors/<int:slot>/', views.professor), | |||
| path('info/', views.info) | |||
| path('info/', views.info), | |||
| path('course_unit/validate', views.verify_course_units) | |||
There was a problem hiding this comment.
You had the name of the url right at the first time 🥲 prior to my suggestion of changing it to course_unit/validate. Meanwhile, the logic changed and the endpoint only returns hashes so maybe it should be course_unit/hash, what do you think? If so, the name of the function in views.py should also be changed to get_course_unit_hashes maybe
There was a problem hiding this comment.
Yes now that the function of the endpoint changed that name makes more sense, thanks for pointing that out
jose-carlos-sousa
force-pushed
the
feature/hashCheckEndpoint
branch
from
914b2b2
to
8e68d6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #92
As requested in the issue description, I implemented: