Fix schedule start time and duration types #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Process-ing
changed the title
Process-ing
force-pushed
the
fix/schedule-time-type
branch
from
a5eb98f
to
3323140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Django,
NUMERICfields are parsed into strings instead of floats, which causes problems in frontend since it expects the fieldsstart_timeanddurationof the slots to be ofnumbertype (eitherintegerorfloat), like in conflict detection. This PR solves this problem by enforcing the type conversion tofloatwhen satissfying the request to theclass/endpoint.