Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

127-importexport-update-input-box-borders #138

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

dsantosferreira
Copy link
Contributor

Closes #127

Added a border to the link's input box, removed the default outline when focusing the input box and changed the DocumentDuplicateIcon size to match the new size of the input box (I can try to keep it with the same size and align its center with the input box's center). I also changed the background of the input box while on dark mode although it wasn't the plan. There are videos below with the design I went for and different variations I tried before reaching the final design. I'd like to know what you like/dislike about what I implemented and if you prefer any of the other options or other combinations.

What I implemented (option 1)

implemented.webm

Option 2 (switched border colors on dark mode)

option2.webm

Option 3

option3.webm

Option 4 (doesn't have the default outline removed)

option4.webm

Option 5

option5.webm

@dsantosferreira dsantosferreira linked an issue Feb 22, 2023 that may be closed by this pull request
@dsantosferreira dsantosferreira self-assigned this Feb 22, 2023
@diogotvf7
Copy link
Contributor

Opção 1!!

@tomaspalma
Copy link
Member

tomaspalma commented Feb 23, 2023

In my opinion, both the options 1 and options 2 provide the smoother transition and contrast specially between the colors, as option 3 in dark mode does not provide enough contrast in the border (even zoomed in, at least for me, it's not as easy to notice) and options 4 and 5 have red-ish borders that don't go well with the rest of the colors.
Between option 1 and option 2 I think I prefer option 1 because the green-to-white border transition highlights more the fact that we clicked on the input than the white-to-green transition in the option 2.
Good job!

@SergioEstevao11
Copy link
Contributor

I prefer option 1 as well. Great Work!

Copy link
Contributor

@SergioEstevao11 SergioEstevao11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve the PR, but if you still need to change the code to implement your chosen option re-request my review.

Copy link
Contributor

@ZeAntonioM ZeAntonioM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the options 1 or 2 seem good to me. Just like Tomás said, these are the ones who provide more contrast, and, for me, the ones who seem to have "cleaner" transitions. I think it could be a good idea if you could make the gray more darker in the white mode, in order to define more the box.
But if everyone agrees in keeping it, i agree.
Great Job!

Copy link
Contributor

@Jumaruba Jumaruba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I also prefer option 1.
Nice work!

@SergioEstevao11 SergioEstevao11 merged commit df5c078 into develop Mar 1, 2023
@SergioEstevao11 SergioEstevao11 deleted the 127-importexport-update-input-box-borders branch May 25, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import&Export: Update input box borders
6 participants