Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare for niployments #243

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Conversation

limwa
Copy link
Member

@limwa limwa commented Aug 13, 2024

No description provided.

Copy link

netlify bot commented Aug 13, 2024

Deploy Preview for tts-fe-preview ready!

Name Link
🔨 Latest commit e4bddd4
🔍 Latest deploy log https://app.netlify.com/sites/tts-fe-preview/deploys/66bd28b673491a000824efc3
😎 Deploy Preview https://deploy-preview-243--tts-fe-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tomaspalma tomaspalma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of tts it is all right 🎉

In terms of the action, it looks correct but im no expert.

@limwa
Copy link
Member Author

limwa commented Aug 13, 2024

Ready to be merged, as soon as secret is set.

@thePeras
Copy link
Member

@tomaspalma do your manager work on the secrets 🔨

@tomaspalma
Copy link
Member

I have already added the TTS_FE_VARS_CONTENT secret 🎉 (hope I didnt mess up 🫠 ).

After this is merged, should I open a PR from develop to main to publish the image?

@limwa
Copy link
Member Author

limwa commented Aug 14, 2024

After this is merged, should I open a PR from develop to main to publish the image?

Yes!

@LuisDuarte1
Copy link
Member

Do we want staging builds on tts though?

@tomaspalma
Copy link
Member

Do we want staging builds on tts though?

I'm not sure if I understand the question, if the code that is on develop is deployed for everyone without the goal to test some of the users shouldn't it be on the main branch? Every feature is working despite a non-critical one that will be fixed soon.

@limwa
Copy link
Member Author

limwa commented Aug 14, 2024

Regarding the staging environments @LuisDuarte1 mentioned, you can think of it as a kind of beta version available on a separate URL. This way, you can test the current state of the develop branch before it is deployed to the production environment, with the main branch. Is the tts team interested in that? @tomaspalma

@tomaspalma
Copy link
Member

tomaspalma commented Aug 14, 2024

Having two action runs?

  • One that runs when there are merges to the main branches that pushes to the niployments image registry a production image that is served on the production url
  • Another one that runs when there are merges to the development branch that updates a beta image that is behind another url in niployments for testing

@limwa
Copy link
Member Author

limwa commented Aug 14, 2024

Having two action runs?

  • One that runs when there are merges to the main branches that pushes to the niployments image registry a production image that is served on the production url
  • Another one that runs when there are merges to the development branch that updates a beta image that is behind another url in niployments for testing

Yes, that's the idea. In practice, it's the same action running on two different branches, but yes, the effect is the same.

@limwa
Copy link
Member Author

limwa commented Aug 14, 2024

@tomaspalma @LuisDuarte1 I've added the necessary changes for a staging environment. If it's not needed, please revert the commit and merge the PR. If you decide it is a good thing, go ahead and merge the PR. I'll do the same in the backend.

@limwa limwa force-pushed the chore/prepare-for-niployments branch from 744adbc to e4bddd4 Compare August 14, 2024 21:59
@tomaspalma
Copy link
Member

tomaspalma commented Aug 14, 2024

I think it is a good idea, a nice to have but not strictly necessary (but it can be kept)

What I didn't understand is how will the develop and main builds be distinguished on the image registry in niployments? Does the action append the branch to the name?

@limwa
Copy link
Member Author

limwa commented Aug 14, 2024

They will have different tags. One will be niaefeup/tts-fe:main and the other will be niaefeup/tts-fe:develop.

@tomaspalma
Copy link
Member

Understood, thank you!

@tomaspalma
Copy link
Member

If you want you can merge this pr, so you get the merge commit

@limwa
Copy link
Member Author

limwa commented Aug 14, 2024

I can't merge the PR because I'm not authorized, but go ahead and merge when you think everything is okay.

@tomaspalma tomaspalma merged commit 1d7b230 into develop Aug 14, 2024
4 checks passed
@tomaspalma tomaspalma deleted the chore/prepare-for-niployments branch October 22, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants