-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare for niployments #243
Conversation
✅ Deploy Preview for tts-fe-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of tts it is all right 🎉
In terms of the action, it looks correct but im no expert.
Ready to be merged, as soon as secret is set. |
@tomaspalma do your manager work on the secrets 🔨 |
I have already added the After this is merged, should I open a PR from develop to main to publish the image? |
Yes! |
Do we want staging builds on tts though? |
I'm not sure if I understand the question, if the code that is on develop is deployed for everyone without the goal to test some of the users shouldn't it be on the main branch? Every feature is working despite a non-critical one that will be fixed soon. |
Regarding the staging environments @LuisDuarte1 mentioned, you can think of it as a kind of beta version available on a separate URL. This way, you can test the current state of the develop branch before it is deployed to the production environment, with the main branch. Is the tts team interested in that? @tomaspalma |
Having two action runs?
|
Yes, that's the idea. In practice, it's the same action running on two different branches, but yes, the effect is the same. |
@tomaspalma @LuisDuarte1 I've added the necessary changes for a staging environment. If it's not needed, please revert the commit and merge the PR. If you decide it is a good thing, go ahead and merge the PR. I'll do the same in the backend. |
744adbc
to
e4bddd4
Compare
I think it is a good idea, a nice to have but not strictly necessary (but it can be kept) What I didn't understand is how will the develop and main builds be distinguished on the image registry in niployments? Does the action append the branch to the name? |
They will have different tags. One will be niaefeup/tts-fe:main and the other will be niaefeup/tts-fe:develop. |
Understood, thank you! |
If you want you can merge this pr, so you get the merge commit |
I can't merge the PR because I'm not authorized, but go ahead and merge when you think everything is okay. |
No description provided.