Fix search major bug #253
Merged
Fix search major bug #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tts-fe-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tomaspalma
approved these changes
Aug 21, 2024
| @@ -48,7 +45,7 @@ const MajorSearchCombobox = ({ selectedMajor, setSelectedMajor }: Props) => { | |||
| aria-expanded={open} | |||
| className="w-full justify-between dark:bg-darker dark:text-slate-50" | |||
| > | |||
| {selectedMajor ? majors.find((major) => major.id === selectedMajor.id)?.name : 'Seleciona um curso...'} | |||
| {selectedMajor ? selectedMajor.name : 'Seleciona um curso...'} | |||
There was a problem hiding this comment.
In this line do you think that we should also display the name of the faculty along the selectedMajor.name as it now also appears on the search results?
There was a problem hiding this comment.
No need, since it also doesn't display the acronym. But if the team decides it could improve the experience, we can add it later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug when I clear the storage and refreshing the page: I select the search major modal and start typing before it fetched the majors. It would break the app by calling some method on undefined. This way, the it returns before making something with the value.
I also have added the faculty to the option name, and refactoring some code.