Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/aggregate academic path page #1102

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Feature/aggregate academic path page #1102

merged 5 commits into from
Feb 7, 2024

Conversation

vitormpp
Copy link
Member

@vitormpp vitormpp commented Feb 2, 2024 •
edited
Loading

Closes #1067

Academic path page: schedule card, exams card, course units card

EN
Screenshot_1706884459

PT
Screenshot_1706882187

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@vitormpp vitormpp linked an issue Feb 2, 2024 that may be closed by this pull request
Implement aggregate "academic path page" #1067
Closed
@bdmendes bdmendes force-pushed the feature/aggregate-academic-path-page branch from 9ae5e15 to 3f2a6f1 Compare February 7, 2024 16:08
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2024 •
edited
Loading

Codecov Report

Merging #1102 (94694a4) into develop (986f363) will decrease coverage by 0%.
Report is 1 commits behind head on develop.
The diff coverage is 2%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           develop   #1102   +/-   ##
=======================================
- Coverage       17%     16%   -0%     
=======================================
  Files          215     217    +2     
  Lines         6514    6564   +50     
=======================================
+ Hits          1044    1045    +1     
- Misses        5470    5519   +49

@bdmendes bdmendes force-pushed the feature/aggregate-academic-path-page branch from 3f2a6f1 to 161a8a0 Compare February 7, 2024 16:56
LuisDuarte1
LuisDuarte1 requested changes Feb 7, 2024
View reviewed changes
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🎉 just have some concerns below.

uni/lib/view/academic_path/widgets/course_units_card.dart Outdated Show resolved Hide resolved
@LuisDuarte1 LuisDuarte1 merged commit d2c3995 into develop Feb 7, 2024
6 checks passed
@LuisDuarte1 LuisDuarte1 deleted the feature/aggregate-academic-path-page branch February 7, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdmendes bdmendes bdmendes approved these changes

@LuisDuarte1 LuisDuarte1 LuisDuarte1 approved these changes

@Process-ing Process-ing Process-ing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement aggregate "academic path page"
4 participants
@vitormpp @LuisDuarte1 @Process-ing @bdmendes