-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get version code from API and use semantic versioning #1109
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1109 +/- ##
=======================================
+ Coverage 16% 16% +1%
=======================================
Files 220 220
Lines 6648 6648
=======================================
+ Hits 1047 1050 +3
+ Misses 5601 5598 -3 |
ffaff26
to
d054eb3
Compare
I've been going through the PR and I have two questions:
|
I think that the edge case is handled by my action because it uses the API call edits.bundles.list which includes all uploaded bundles, even rejected ones, which resolves the duplication of the version code (which is the most important, because it must be unique). I'm not too sure about the duplication of the version name, but it's generally accepted on the marketplaces (and this edge case will not happen frequently, so the eventual duplication of one version name is acceptable imo).
The old action stored the version exclusively in the repository, using a We make some assumptions about the master branch, to simplify the action itself: we assume that the master branch will always be protected, in a way, that requires a PR that is merged using a merge commit. We use the original branch hash, to evaluate if the commit came from develop or not (this was somewhat done in the previous action too). This is used mainly for versioning, a commit that comes from develop bumps the minor version, but if it doesn't come from develop (which means it's a fix) it bumps the patch version. There are also other ways to do this, such as relying on |
4e332e1
to
3d1c25f
Compare
Closes #985
Closes #1108
This makes the versioning more versatile by: