Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use cached profile image on navigation #1113

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

limwa
Copy link
Member

@limwa limwa commented Feb 7, 2024

This PR prevents the users' profile image from being downloaded on every app navigation. It seems some legacy code was kept and it was preventing the cache mechanism from working properly.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@limwa limwa requested a review from a team February 7, 2024 20:06
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Merging #1113 (0c0f0f7) into develop (94694a4) will not change coverage.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1113   +/-   ##
=======================================
  Coverage       16%     16%           
=======================================
  Files          217     217           
  Lines         6564    6564           
=======================================
  Hits          1045    1045           
  Misses        5519    5519           

@bdmendes bdmendes merged commit 270190b into develop Feb 7, 2024
4 checks passed
@bdmendes bdmendes deleted the fix/use-cached-profile-image branch February 7, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants