New PR template #1248
Open
New PR template #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1248 +/- ##
=======================================
Coverage 12% 12%
=======================================
Files 266 266
Lines 7201 7201
=======================================
Hits 806 806
Misses 6395 6395 |
limwa
reviewed
Jun 24, 2024
thePeras
force-pushed
the
refactor/pr-template
branch
from
d2cacc0
to
d91f57f
Compare
limwa
reviewed
Jun 26, 2024
| # Review Checklist | ||
|
|
||
| - [ ] Writes a summary in `whatsnew/whatsnew-pt-PT` of the new changes | ||
| - [ ] Terms and conditions reflect the changes |
There was a problem hiding this comment.
Terms and conditions should be updated on every PR, if necessary. The reason is the app will be used by beta testers, which are also subject to the terms and conditions of uni.
There was a problem hiding this comment.
I think it can be a little annoying and pushing the responsibility to the person who made the release and its reviews, will allow taking a preoccupation from each PR
|
UI/UX Test with diferent text zoom levels |
|
Add something responsive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #997
Let's open the debate!!