-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new schedule api #1281
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1281 +/- ##
=======================================
- Coverage 16% 16% -0%
=======================================
Files 233 239 +6
Lines 7220 7172 -48
=======================================
- Hits 1139 1078 -61
- Misses 6081 6094 +13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into the code, seems very nice!
- Can we put the response models inside a specific folder? ex
lecture_response
- Are we keeping the old api code?
uni/lib/controller/fetchers/schedule_fetcher/schedule_fetcher_new_api.dart
Outdated
Show resolved
Hide resolved
uni/lib/controller/fetchers/schedule_fetcher/schedule_fetcher_new_api.dart
Outdated
Show resolved
Hide resolved
The response models are already inside the
I was under the impression we were, but I'm happy to remove it 😄 |
Sorry, I miss looked the folder. It's nice this way!
It seems pretty solid, but am not opposing of keeping |
4c60524
to
5de8cea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have schedules to test, but it seems good to me.
Nice work and what a pleasure to see so much code deleted!
✅ 🛫
packages/uni_app/lib/controller/parsers/schedule/new_api/parser.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! 🚀
Closes #1254.
Closes #1280.
Implements behavior to retrieve a user's schedule from the new schedule API.
For now, it reads the HTML from the schedule page and uses the information to retrieve the schedule data from the API.
Removes the old HTML parsing code.
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change