Add background workers functionality and notification background support #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sirze01 <Sirze01@users.noreply.github.com>
Co-authored-by: Sirze01 <Sirze01@users.noreply.github.com>
LuisDuarte1
changed the title
… shows when at least the app opens
|
|
|
Agora com icone |
|
Toggle para as notificações |
Sirze01
requested changes
Jan 19, 2023
uni/lib/controller/backgroundWorkers/notifications/tuition_notification.dart
Outdated
Show resolved
Hide resolved
…os run in the main isolate
|
It appears to working as expected! The only thing lasting is to discuss if the notifications are to be defaulted enable or not, as it can be annoying to be asked to accept notifications launching the app for the first time. |
bdmendes
requested changes
Feb 23, 2023
There was a problem hiding this comment.
This is a very complex issue, so congratulations on the results! However, the code is still far from ready regarding readability and tidiness. I have left some suggestions; on top of that, please review all the changes and format the code properly.
I'll test this more extensively when you get the chance to improve on this, please let me know then.
uni/lib/controller/background_workers/notifications/tuition_notification.dart
Outdated
Show resolved
Hide resolved
bdmendes
requested changes
Mar 9, 2023
uni/lib/controller/background_workers/notifications/tuition_notification.dart
Outdated
Show resolved
Hide resolved
thePeras
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work for displaying notifications when even UNI is closed
Add workerCallback (iOS and android support)
Add NotificationManager (android support only for now, because I need a macbook to complete background worker support).
Review checklist
whatsnew/whatsnew-pt-PTchangelog.mdwith the change