Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewriting tests #675

Merged
merged 10 commits into from
Jul 3, 2023
Merged

Rewriting tests #675

merged 10 commits into from
Jul 3, 2023

Conversation

thePeras
Copy link
Member

@thePeras thePeras commented Jan 14, 2023 •
edited
Loading

Rewrite tests to work with providers implemented in #617.

  • View Unit Tests
  • Old Redux Unit Tests, now Providers Tests
  • Integration Tests

Base automatically changed from refactor/state-providers to develop March 4, 2023 14:45
@thePeras thePeras force-pushed the refactor/tests branch 3 times, most recently from fa0b0f6 to 09f97b4 Compare March 8, 2023 16:23
@thePeras thePeras marked this pull request as ready for review March 8, 2023 16:26
bdmendes
bdmendes requested changes Mar 8, 2023
View reviewed changes
uni/test/test_widget.dart Outdated Show resolved Hide resolved
@bdmendes
Copy link
Member

bdmendes commented Mar 9, 2023

I've been trying to improve the testableWidget function and I'm getting the same error that makes no sense to me. I've asked a StackOverflow question about this: https://stackoverflow.com/questions/75687347/cant-provide-changenotifier-passed-via-argument
We can wait some days for it to be answered, I hope.

@thePeras thePeras requested a review from bdmendes April 11, 2023 17:53
bdmendes
bdmendes previously approved these changes Apr 30, 2023
View reviewed changes
Copy link
Member

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested once again with the SO's answer and it still does not work, not sure why. Since this is quite important, I am approving.

LuisDuarte1
LuisDuarte1 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

bdmendes
bdmendes approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bdmendes bdmendes merged commit 0adc622 into develop Jul 3, 2023
@bdmendes bdmendes deleted the refactor/tests branch July 3, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuisDuarte1 LuisDuarte1 LuisDuarte1 approved these changes

@bdmendes bdmendes bdmendes approved these changes

@SocksDevil SocksDevil Awaiting requested review from SocksDevil

@brunogomes30 brunogomes30 Awaiting requested review from brunogomes30

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thePeras @bdmendes @LuisDuarte1