Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated to flutter 3.7.2 #701

Merged
merged 15 commits into from
Apr 27, 2023
Merged

updated to flutter 3.7.2 #701

merged 15 commits into from
Apr 27, 2023

Conversation

jamal-o
Copy link
Contributor

@jamal-o jamal-o commented Feb 11, 2023 •
edited
Loading

Closes #661

The issue was to update Flutter to 3.3.10+
The latest plugin updates are requiring API >=32. Currently, we are using Flutter 3.3.2, which resorts to 31. The code was migrated to flutter 3.7.2 and dependencies were updated.

P.s This is my first pull request. Any feedback is appreciated.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes new summary in whatsnew/whatsnew-pt-PT
  • Properly adds entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well structured code

bdmendes
bdmendes reviewed Feb 12, 2023
View reviewed changes
Copy link
Member

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jamal-o! Thanks for your contribution. Does the app compile and run faster/as well?
Also, you can remove the guidance placeholder in your PR description.

@jamal-o
Copy link
Contributor Author

jamal-o commented Feb 13, 2023

Hi @bdmendes! Yes, I believe it compiles and runs faster.
I have also removed the placeholder from the original comment.

@jamal-o jamal-o closed this Feb 13, 2023
@jamal-o jamal-o reopened this Feb 13, 2023
thePeras
thePeras requested changes Feb 13, 2023
View reviewed changes
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jamal-o, thanks for the contributing!

Don't forget to also update the GitHub workflows (deploy.yaml, test_lint.yaml).

With this new flutter upgrade, there are some things deprecated in TextTheme (headline1-6, subtitle1-2, bodyText1-2, caption)
And also backgroundColor, toggleableActiveColor at ThemeData.
Can you check that?

@jamal-o
Copy link
Contributor Author

jamal-o commented Feb 19, 2023

Hi @thePeras!

I have implemented the changes to the deprecated features as requested.

@thePeras
Copy link
Member

Hey @jamal-o, are you able to login into the app?

@jamal-o
Copy link
Contributor Author

jamal-o commented Mar 2, 2023

Hi! Please can I get a little help with the github workflows. Other than that what else is required for this PR?

thePeras
thePeras reviewed Mar 3, 2023
View reviewed changes
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the branch with develop and done the workflows migrations.
Everything is ready for review now

bdmendes
bdmendes requested changes Mar 8, 2023
View reviewed changes
Copy link
Member

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app seems to be working well with no visible theme changes. Left a few suggestions.

uni/lib/view/theme.dart Outdated Show resolved Hide resolved
uni/lib/view/theme.dart Outdated Show resolved Hide resolved
@thePeras thePeras mentioned this pull request Mar 9, 2023
Closed
7 tasks
@thePeras thePeras force-pushed the fix/update-flutter-to-3.3.10+ branch from 1025fda to 73f30cf Compare March 22, 2023 17:10
@thePeras
Copy link
Member

Dark switch theme fixed.

Screenshot 2023-03-22 at 16 41 50

Screenshot 2023-03-22 at 16 41 44

And PR ready to review

@thePeras thePeras requested a review from bdmendes April 11, 2023 22:40
thePeras
thePeras previously approved these changes Apr 13, 2023
View reviewed changes
coutinho21
coutinho21 previously approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@coutinho21 coutinho21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bdmendes bdmendes dismissed stale reviews from coutinho21 and thePeras via 048dbb1 April 26, 2023 15:13
@bdmendes bdmendes linked an issue Apr 26, 2023 that may be closed by this pull request
Favorite buses are not being stored in the database properly #749
Closed
bdmendes
bdmendes approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thePeras thePeras merged commit 9a3a701 into NIAEFEUP:develop Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePeras thePeras thePeras approved these changes

@bdmendes bdmendes bdmendes approved these changes

@brunogomes30 brunogomes30 Awaiting requested review from brunogomes30

@coutinho21 coutinho21 Awaiting requested review from coutinho21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Favorite buses are not being stored in the database properly Update Flutter to 3.3.10+
4 participants
@jamal-o @thePeras @bdmendes @coutinho21