Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse and save meals in UTC to avoid daylight saving time offsets and… #771

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Parse and save meals in UTC to avoid daylight saving time offsets and… #771

merged 1 commit into from
Mar 20, 2023

Conversation

Sirze01
Copy link
Contributor

@Sirze01 Sirze01 commented Mar 20, 2023 •
edited
Loading

… simplify filter to be time agnostic

Closes #770

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Naapperas
Naapperas approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@Naapperas Naapperas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: 🚀 👍 💯 🥇

@Sirze01 Sirze01 self-assigned this Mar 20, 2023
LuisDuarte1
LuisDuarte1 approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀 🚀

@Sirze01 Sirze01 merged commit b7b83ba into develop Mar 20, 2023
@Sirze01 Sirze01 deleted the fix/meal-filter-daylight-saving branch March 20, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naapperas Naapperas Naapperas approved these changes

@LuisDuarte1 LuisDuarte1 LuisDuarte1 approved these changes

@bdmendes bdmendes Awaiting requested review from bdmendes

@thePeras thePeras Awaiting requested review from thePeras

Assignees

@Sirze01 Sirze01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Next monday meals in canteen's page
3 participants
@Sirze01 @Naapperas @LuisDuarte1