-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change env.json to .env file #784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove parseJsonFromAssets
now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The app does not load now if the .env file is not present (dotenv.load(isOptional = false)
is set). This might or might not be the desired behaviour; if it is, make sure to catch the exception and flash the logger.
I don't think we want to stop the app just because the .env was not loaded, which unique break situation is to submit bugs/feedback. I think it may be optional |
In that case, flash the logger, so that the developer expects the app to crash when a bug report is submitted |
There is already an error log for that case: "Error while posting bug report:Exception: Network error" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the method. Apart from that it is great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Closes #718
I will put a handler to check if the env exists/was successfully loaded when submitting a bug/suggestion.
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change