Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change env.json to .env file #784

Merged
merged 8 commits into from
Jul 10, 2023
Merged

Change env.json to .env file #784

merged 8 commits into from
Jul 10, 2023

Conversation

thePeras
Copy link
Member

Closes #718

I will put a handler to check if the env exists/was successfully loaded when submitting a bug/suggestion.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Copy link
Member

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove parseJsonFromAssets now?

@thePeras thePeras marked this pull request as ready for review June 21, 2023 15:16
Copy link
Member

@bdmendes bdmendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app does not load now if the .env file is not present (dotenv.load(isOptional = false) is set). This might or might not be the desired behaviour; if it is, make sure to catch the exception and flash the logger.

@thePeras
Copy link
Member Author

thePeras commented Jul 3, 2023

The app does not load now if the .env file is not present (dotenv.load(isOptional = false) is set). This might or might not be the desired behaviour; if it is, make sure to catch the exception and flash the logger.

I don't think we want to stop the app just because the .env was not loaded, which unique break situation is to submit bugs/feedback. I think it may be optional

@bdmendes
Copy link
Member

bdmendes commented Jul 3, 2023

In that case, flash the logger, so that the developer expects the app to crash when a bug report is submitted

@thePeras
Copy link
Member Author

thePeras commented Jul 3, 2023

In that case, flash the logger, so that the developer expects the app to crash when a bug report is submitted

There is already an error log for that case: "Error while posting bug report:Exception: Network error"

@thePeras thePeras requested a review from bdmendes July 3, 2023 16:38
bdmendes
bdmendes previously approved these changes Jul 3, 2023
Copy link
Contributor

@Sirze01 Sirze01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the method. Apart from that it is great.

uni/lib/view/bug_report/widgets/form.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@Sirze01 Sirze01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bdmendes bdmendes merged commit 178b125 into develop Jul 10, 2023
3 checks passed
@bdmendes bdmendes deleted the feature/dotenv branch July 10, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change env.json to .env
3 participants