Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make build run on dev and master pushes #897

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Make build run on dev and master pushes #897

merged 1 commit into from
Aug 10, 2023

Conversation

bdmendes
Copy link
Member

@bdmendes bdmendes commented Aug 1, 2023 •
edited
Loading

Closes #896
This makes format_lint_test GH action run on develop and master, with the following tradeoffs:

  • pro: status badge always point to stable branch; broken PRs no longer break it
  • pro: safeguard in case of admin force push mistake
  • pro: allows test coverage to be on the default branch after Add code cov to test step #898
  • con: some more minutes spent; we never had problems with it

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@bdmendes bdmendes force-pushed the doc/improve-badges branch 2 times, most recently from 9abec3b to e695533 Compare August 1, 2023 19:32
LuisDuarte1
LuisDuarte1 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@LuisDuarte1 LuisDuarte1 merged commit d49b169 into develop Aug 10, 2023
4 checks passed
@LuisDuarte1 LuisDuarte1 deleted the doc/improve-badges branch August 10, 2023 20:08
@LuisDuarte1 LuisDuarte1 restored the doc/improve-badges branch August 10, 2023 20:08
@LuisDuarte1 LuisDuarte1 deleted the doc/improve-badges branch August 10, 2023 20:08
@LuisDuarte1 LuisDuarte1 restored the doc/improve-badges branch August 10, 2023 20:08
@LuisDuarte1 LuisDuarte1 deleted the doc/improve-badges branch August 10, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuisDuarte1 LuisDuarte1 LuisDuarte1 approved these changes

@Process-ing Process-ing Process-ing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make format_lint_test run on develop and master
3 participants
@bdmendes @LuisDuarte1 @Process-ing