Refactor common widgets #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdmendes
reviewed
Aug 10, 2023
uni/lib/view/common_widgets/pages_layouts/general/widgets/navigation_drawer.dart
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #903 +/- ##
======================================
+ Coverage 17% 17% +1%
======================================
Files 207 212 +5
Lines 6418 6434 +16
======================================
+ Hits 1037 1042 +5
- Misses 5381 5392 +11 |
bdmendes
force-pushed
the
refactor/common-widgets
branch
from
e9ebcf2
to
bc38e49
Compare
bdmendes
requested changes
Aug 19, 2023
uni/lib/view/common_widgets/pages_layouts/general/widgets/refresh_state.dart
Show resolved
Hide resolved
niaefeup-admin
dismissed
LuisDuarte1’s stale review
The merge-base changed after approval.
niaefeup-admin
force-pushed
the
develop
branch
from
43e6780
to
d2ed63a
Compare
bdmendes
requested changes
Nov 10, 2023
uni/lib/view/common_widgets/widgets/request_failed_message.dart
Outdated
Show resolved
Hide resolved
uni/lib/view/common_widgets/widgets/request_failed_message.dart
Outdated
Show resolved
Hide resolved
|
@Process-ing any progress on this? |
Process-ing
force-pushed
the
refactor/common-widgets
branch
2 times, most recently
from
cacdf3c
to
fb31eb6
Compare
bdmendes
requested changes
Jan 6, 2024
uni/lib/view/common_widgets/pages_layouts/general/widgets/refresh_state.dart
Show resolved
Hide resolved
Process-ing
force-pushed
the
refactor/common-widgets
branch
from
7fb2b31
to
7231975
Compare
bdmendes
previously approved these changes
Jan 19, 2024
LuisDuarte1
requested changes
Jan 26, 2024
uni/lib/view/common_widgets/pages_layouts/general/widgets/top_right_button.dart
Outdated
Show resolved
Hide resolved
Process-ing
force-pushed
the
refactor/common-widgets
branch
from
baf12b4
to
51d60c4
Compare
LuisDuarte1
previously approved these changes
Jan 26, 2024
LuisDuarte1
approved these changes
Jan 26, 2024
bdmendes
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #900
Review checklist
whatsnew/whatsnew-pt-PTchangelog.mdwith the change