Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/init hang #911

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Fix/init hang #911

merged 3 commits into from
Aug 31, 2023

Conversation

bdmendes
Copy link
Member

Closes #910

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@codecov
Copy link

codecov bot commented Aug 13, 2023 •
edited
Loading

Codecov Report

Merging #911 (3959c83) into develop (078d9e3) will decrease coverage by 0%.
Report is 2 commits behind head on develop.
The diff coverage is 22%.

Additional details and impacted files 
@@          Coverage Diff           @@
##           develop   #911   +/-   ##
======================================
- Coverage       22%    21%   -0%     
======================================
  Files          136    136           
  Lines         3532   3540    +8     
======================================
- Hits           746    740    -6     
- Misses        2786   2800   +14

LuisDuarte1
LuisDuarte1 requested changes Aug 14, 2023
View reviewed changes
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 🚀 , just have one concern below

uni/lib/controller/local_storage/app_shared_preferences.dart Show resolved Hide resolved
@LuisDuarte1 LuisDuarte1 mentioned this pull request Aug 16, 2023
Open
LuisDuarte1
LuisDuarte1 previously approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bdmendes bdmendes force-pushed the fix/init-hang branch 2 times, most recently from 74ea892 to 4c4ef53 Compare August 18, 2023 12:59
LuisDuarte1
LuisDuarte1 approved these changes Aug 20, 2023
View reviewed changes
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bdmendes bdmendes requested a review from thePeras August 20, 2023 18:35
@bdmendes bdmendes force-pushed the fix/init-hang branch 3 times, most recently from 383e242 to f3ead79 Compare August 24, 2023 13:47
@bdmendes
Copy link
Member Author

@thePeras @Sirze01 can you look at this?

Sirze01
Sirze01 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@Sirze01 Sirze01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working as expected.

@bdmendes bdmendes merged commit 6b9e52c into develop Aug 31, 2023
6 checks passed
@bdmendes bdmendes deleted the fix/init-hang branch August 31, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuisDuarte1 LuisDuarte1 LuisDuarte1 approved these changes

@Sirze01 Sirze01 Sirze01 approved these changes

@thePeras thePeras Awaiting requested review from thePeras

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix concurrent login requests
3 participants
@bdmendes @LuisDuarte1 @Sirze01