Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/remove splash #919

Merged
merged 4 commits into from
Aug 20, 2023
Merged

Refactor/remove splash #919

merged 4 commits into from
Aug 20, 2023

Conversation

bdmendes
Copy link
Member

@bdmendes bdmendes commented Aug 19, 2023

Closes #850
This refactors the initial route logic, making it immediately the login or the home screen depending on the saved info state. Also tweaks offline image storage to trigger a login if a new request is needed.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@bdmendes bdmendes requested review from LuisDuarte1 and thePeras and removed request for LuisDuarte1 August 19, 2023 12:08
@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #919 (b051cf9) into develop (77631b1) will decrease coverage by 10.28%.
Report is 2 commits behind head on develop.
The diff coverage is 10.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #919       +/-   ##
============================================
- Coverage    31.47%   21.20%   -10.28%     
============================================
  Files           81      136       +55     
  Lines         2364     3514     +1150     
============================================
+ Hits           744      745        +1     
- Misses        1620     2769     +1149     
Files Changed Coverage Δ
uni/lib/controller/cleanup.dart 0.00% <0.00%> (ø)
...controller/local_storage/file_offline_storage.dart 19.04% <0.00%> (-4.49%) ⬇️
uni/lib/controller/networking/network_router.dart 24.13% <0.00%> (ø)
uni/lib/model/entities/exam.dart 54.83% <0.00%> (ø)
.../lib/model/providers/startup/profile_provider.dart 7.89% <0.00%> (-2.50%) ⬇️
.../lib/model/providers/startup/session_provider.dart 0.00% <0.00%> (ø)
...i/lib/model/providers/state_provider_notifier.dart 20.00% <ø> (ø)
uni/lib/utils/drawer_items.dart 0.00% <0.00%> (ø)
uni/lib/view/navigation_service.dart 0.00% <0.00%> (ø)
.../common_widgets/pages_layouts/general/general.dart 70.00% <75.00%> (+1.03%) ⬆️

... and 56 files with indirect coverage changes

Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job 🚀

Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working in IOS really nice!

@thePeras thePeras merged commit 766fb6b into develop Aug 20, 2023
4 of 6 checks passed
@thePeras thePeras deleted the refactor/remove-splash branch August 20, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove splash screen
3 participants