-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/remove splash #919
Conversation
3f34f7b
to
f77db9a
Compare
f77db9a
to
b051cf9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #919 +/- ##
============================================
- Coverage 31.47% 21.20% -10.28%
============================================
Files 81 136 +55
Lines 2364 3514 +1150
============================================
+ Hits 744 745 +1
- Misses 1620 2769 +1149
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice job 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working in IOS really nice!
Closes #850
This refactors the initial route logic, making it immediately the login or the home screen depending on the saved info state. Also tweaks offline image storage to trigger a login if a new request is needed.
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change