-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix theme issues on login page #922
Conversation
0902b05
to
20fb792
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #922 +/- ##
===========================================
- Coverage 21.22% 21.21% -0.02%
===========================================
Files 136 136
Lines 3514 3511 -3
===========================================
- Hits 746 745 -1
+ Misses 2768 2766 -2
|
Just that? What changed? |
The widgets were being generated as children of the context outside the theme (see the variable name change). |
Oh, I see it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ 🛫
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
fa04b26
to
af9d64f
Compare
Closes #907
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change