Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theme issues on login page #922

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Fix theme issues on login page #922

merged 1 commit into from
Aug 22, 2023

Conversation

bdmendes
Copy link
Member

Closes #907

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #922 (fa04b26) into develop (913d188) will decrease coverage by 0.02%.
Report is 1 commits behind head on develop.
The diff coverage is 0.00%.

❗ Current head fa04b26 differs from pull request most recent head af9d64f. Consider uploading reports for the commit af9d64f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #922      +/-   ##
===========================================
- Coverage    21.22%   21.21%   -0.02%     
===========================================
  Files          136      136              
  Lines         3514     3511       -3     
===========================================
- Hits           746      745       -1     
+ Misses        2768     2766       -2     
Files Changed Coverage Δ
uni/lib/view/login/login.dart 0.67% <0.00%> (+0.01%) ⬆️

... and 2 files with indirect coverage changes

@thePeras
Copy link
Member

Just that? What changed?

@bdmendes
Copy link
Member Author

Just that? What changed?

The widgets were being generated as children of the context outside the theme (see the variable name change).

@thePeras
Copy link
Member

Just that? What changed?

The widgets were being generated as children of the context outside the theme (see the variable name change).

Oh, I see it! createSafeLoginButton(context) sneaky bastard

Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 🛫

Copy link
Contributor

@Process-ing Process-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@bdmendes bdmendes merged commit 192deef into develop Aug 22, 2023
8 checks passed
@bdmendes bdmendes deleted the fix/login-theme branch August 22, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix login button text
3 participants