Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status parsing of multiple year UCs #953

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

bdmendes
Copy link
Member

Closes #947

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #953 (b15861a) into develop (2e04b64) will increase coverage by 1%.
Report is 2 commits behind head on develop.
The diff coverage is 0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           develop   #953   +/-   ##
======================================
+ Coverage       22%    22%   +1%     
======================================
  Files          142    142           
  Lines         4357   4356    -1     
======================================
  Hits           954    954           
+ Misses        3403   3402    -1     

@bdmendes bdmendes force-pushed the fix/multiple-year-ucs-parser branch 2 times, most recently from 15bc72d to 2cf0036 Compare September 20, 2023 16:12
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 🛫 Working as expected!

@LuisDuarte1 LuisDuarte1 merged commit a39c706 into develop Sep 20, 2023
6 checks passed
@LuisDuarte1 LuisDuarte1 deleted the fix/multiple-year-ucs-parser branch September 20, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing UC status
3 participants