Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix user password encryption #958

Merged
merged 3 commits into from
Sep 23, 2023
Merged

Fix user password encryption #958

merged 3 commits into from
Sep 23, 2023

Conversation

bdmendes
Copy link
Member

Closes #957

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@codecov
Copy link

codecov bot commented Sep 23, 2023 •
edited
Loading

Codecov Report

Merging #958 (c1e3c96) into develop (3501e0d) will decrease coverage by 0%.
Report is 1 commits behind head on develop.
The diff coverage is 0%.

Additional details and impacted files 
@@          Coverage Diff           @@
##           develop   #958   +/-   ##
======================================
- Coverage       22%    22%   -0%     
======================================
  Files          142    142           
  Lines         4356   4353    -3     
======================================
- Hits           954    952    -2     
+ Misses        3402   3401    -1

@bdmendes bdmendes mentioned this pull request Sep 23, 2023
Merged
7 tasks
limwa
limwa approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@limwa limwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@limwa limwa merged commit 743e4c6 into develop Sep 23, 2023
6 checks passed
@limwa limwa deleted the fix/bump-encrypt branch September 23, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limwa limwa limwa approved these changes

@thePeras thePeras thePeras approved these changes

@LuisDuarte1 LuisDuarte1 Awaiting requested review from LuisDuarte1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login with persistent session is failing
3 participants
@bdmendes @limwa @thePeras