Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle provider errors on the abstract class #977

Merged
merged 6 commits into from
Sep 29, 2023

Conversation

bdmendes
Copy link
Member

Closes #976

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #977 (9d145da) into master (e88317d) will increase coverage by 1%.
Report is 2 commits behind head on master.
The diff coverage is 20%.

Additional details and impacted files
@@          Coverage Diff          @@
##           master   #977   +/-   ##
=====================================
+ Coverage      22%    23%   +1%     
=====================================
  Files         143    143           
  Lines        4368   4346   -22     
=====================================
+ Hits          953    962    +9     
+ Misses       3415   3384   -31     

@bdmendes bdmendes changed the base branch from develop to master September 28, 2023 14:52
Copy link
Member

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the login succeeds but it won't redirect to the main page for some reason. Can you look at this?

@bdmendes bdmendes force-pushed the refactor-provider-state branch 2 times, most recently from 0ea958e to 01d728a Compare September 28, 2023 22:25
@LuisDuarte1 LuisDuarte1 merged commit 14e7f05 into master Sep 29, 2023
6 checks passed
@LuisDuarte1 LuisDuarte1 deleted the refactor-provider-state branch September 29, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle provider errors globally
2 participants