-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/api parsing for half duration lectures #981
Hotfix/api parsing for half duration lectures #981
Conversation
@bdmendes should this PR target Also, does this PR require a whatsnew and a changelog entry? I am not entirely familiar with the process in uni. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #981 +/- ##
======================================
+ Coverage 22% 23% +1%
======================================
Files 143 143
Lines 4357 4349 -8
======================================
+ Hits 948 964 +16
+ Misses 3409 3385 -24 |
You should change it into master, since it's a hotfix
I think you don't need to do that |
We are migrating away from the changelog file in favor of automated releases soon, so no need. The whatsnew is usually generic for the stores description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, good work and nice catch, this was impossible to test for when we did the linting changes, change the base to master and I'll merge this
The base branch was changed.
This PR introduces a hotfix to a problem where the API parsing throws an exception when aula_duracao, in the API response, is a double (1.5 for a lecture that lasts for 1h30min). This was done by checking if the value is a double and, if so, multiply it by two and only then cast it to an integer, instead of converting the result to an integer.
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change