Misc release hotfixes

[bdmendes]

Closes #993
Closes #994

Review checklist

• Terms and conditions reflect the current change
• Contains enough appropriate tests
• If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
• Properly adds an entry in changelog.md with the change
• If PR includes UI updates/additions, its description has screenshots
• Behavior is as expected
• Clean, well-structured code

[codecov]

Codecov Report

Merging #986 (59558fc) into master (393a639) will decrease coverage by 6%.
Report is 1 commits behind head on master.
The diff coverage is 9%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #986     +/-   ##
=======================================
- Coverage      23%    16%     -6%     
=======================================
  Files         143    201     +58     
  Lines        4355   6361   +2006     
=======================================
+ Hits          959    986     +27     
- Misses       3396   5375   +1979     

[limwa]

I just have one question regarding the use of unawaited. Everything else looks good to me!

[limwa]

Well done!

[LuisDuarte1]

It looks like the ProfileProvider is timing out for me, can you look into that?

The storage is also timing out for some reason

[limwa]

It looks like the ProfileProvider is timing out for me, can you look into that?

The storage is also timing out for some reason

[limwa]

It looks like the ProfileProvider is timing out for me, can you look into that? The storage is also timing out for some reason

Is that running on an emulator? I can't reproduce it in my emulator.

[limwa]

@bdmendes an || !context.mounted is missing here https://github.com/NIAEFEUP/uni/blob/hotfix/release-errors/uni/lib/view/common_widgets/pages_layouts/general/general.dart#L28

[bdmendes]

@limwa it sure does, but is that related to the issue @LuisDuarte1 is having?
@LuisDuarte1 have you tried with a different internet connection, and is the issue non present on upstream?

[limwa]

@limwa it sure does, but is that related to the issue @LuisDuarte1 is having?
@LuisDuarte1 have you tried with a different internet connection, and does is the issue non present on upstream?

No, I don't think so, it was just something that came across while testing.

[LuisDuarte1]

I will test this further, but on other note, I think that the profile provider shouldn't have a timeout (or it should have a timeout greater than the rest of the providers) since it's needed at startup, this should reduce the problem with slow internet connections.

[limwa]

I will test this further, but on other note, I think that the profile provider shouldn't have a timeout (or it should have a timeout greater than the rest of the providers) since it's needed at startup, this should reduce the problem with slow internet connections.

I also suggest, if it's easier to implement, to set the timeout on this provider (or all providers) to 30 seconds. Should be more than enough, even for slow connections.

[limwa]

LGTM 🚀