Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events listing page #163

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

Events listing page #163

wants to merge 8 commits into from

Conversation

DoStini
Copy link
Member

@DoStini DoStini commented Apr 28, 2023

Closes #14

Screenshots

Generalized TextField that allows pre and after icons that might act as buttons (see IconOptions)

image

Review checklist

  • Contains enough appropriate tests
  • Behavior is as expected
  • Clean, well-structured code

@DoStini DoStini changed the title Fix navbar not clickable and add events title Events listing page Apr 28, 2023
@BrunoRosendo
Copy link
Member

image
please fix, related to z-index

@BrunoRosendo BrunoRosendo linked an issue May 3, 2023 that may be closed by this pull request
@BrunoRosendo
Copy link
Member

open issue in svelte-select repo because of dropdown not closing

@limwa
Copy link
Member

limwa commented Jun 28, 2023

Regarding the select component, React has a very popular library for customizable components called Radix UI (https://www.radix-ui.com/). Although the original project doesn't support Svelte yet, we can look for some "ports", like https://www.radix-svelte.com/ (replaced by https://www.melt-ui.com/). These two last libraries are not production ready, but I'll keep looking for some libraries similar to Radix UI for Svelte

@limwa
Copy link
Member

limwa commented Jun 28, 2023

It appears the Svelte ecosystem in this area is still a bit underdeveloped... Going with custom components made by ourselves seems like the safest bet.

@DoStini DoStini self-assigned this Jul 3, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8585cf0) 95.38% compared to head (db81563) 95.38%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #163   +/-   ##
========================================
  Coverage    95.38%   95.38%           
========================================
  Files           16       16           
  Lines          130      130           
  Branches        18       18           
========================================
  Hits           124      124           
  Misses           6        6           
Files Changed Coverage Δ
src/lib/component/Icons.ts 100.00% <ø> (ø)
src/lib/layout/BackgroundHexagon.svelte 100.00% <ø> (ø)
src/lib/layout/Navbar.svelte 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuisDuarte1 LuisDuarte1 mentioned this pull request Sep 24, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

events: basic listing page Fix background image overlapping other components
4 participants