Login page #214
Login page #214
Conversation
There was a problem hiding this comment.
Good progress overall 🚀, besides responsiveness and the color issue in tailwind which you are working on, the scaling looks weird on a display with lower vertical resolution (which is the first image in this case, and the case with my laptop 😄 ) maybe the login should scale down accordingly to make the experience more consistent
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #214 +/- ##
==========================================
- Coverage 1.01% 0.86% -0.15%
==========================================
Files 49 51 +2
Lines 1584 1857 +273
Branches 51 53 +2
==========================================
Hits 16 16
- Misses 1521 1792 +271
- Partials 47 49 +2 ☔ View full report in Codecov by Sentry. |
|
Also, it'd be nice to have this in storybook too |
I tried replicating this placing small icons on top of the input but I couldn't. Could you maybe inspect the page and share the code, or let me know the extension name? |
MRita443
force-pushed
the
feature/login-page
branch
from
bfc24da
to
5e7548f
Compare
There was a problem hiding this comment.
Nice progress, it's not 100% responsive yet though, as you can see on my phone, the login is not properly centered and overlapping the hamburger menu:
Also it seems that you have an issue with importing layout from login/page.stories.ts that causes storybook to fail 😅
|
@BrunoRosendo @LuisDuarte1 pls re-review :) |
src/routes/(app)/login/+page.svelte
Outdated
| <br /> | ||
| <button><a href="/profile">Profile</a></button> | ||
| </form> | ||
| <!-- Colocar a página toda scrollable incluindo footer, ver container queries --> |
There was a problem hiding this comment.
| <!-- Colocar a página toda scrollable incluindo footer, ver container queries --> |
There was a problem hiding this comment.
is this still a problem? I don't think so
There was a problem hiding this comment.
It seems like it is a problem on really short screens, but a general one at that because it happens not only on this page.
Do you think this is worth concerning about? I might open a new issue on it
There was a problem hiding this comment.
Ah I see! Open an issue, we can think about a fix later on
There was a problem hiding this comment.
I think this is fixed by #278, I thought this was a problem just with the mobile sidebar and didn't notice this case but it's fixed too
|
@LuisDuarte1 pls re-review |
Closes #140
Initial implementation of member login page
Screenshots
Review checklist