Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.1.0 #13

Merged
merged 15 commits into from
Feb 16, 2024
Merged

0.1.0 #13

merged 15 commits into from
Feb 16, 2024

Conversation

sigmafelix
Copy link
Collaborator

No description provided.

sigmafelix and others added 12 commits February 9, 2024 14:03
- Process_* functions
- tidyr is added to DESCRIPTION
- renamed
- documents were revised
- Not tested yet
- stdt part is gradually decommissioned
- Tests were revised and added
- temporal coverage comparison is temporarily removed
- Gradually deprecating stdt
- Tests on added functions
- Established process_--Spat* & calc_--data.frame
- TODO: wrapper function refactoring (needs discussion)
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6000bd0) 93.77% compared to head (b88ed8b) 94.45%.

Files Patch % Lines
R/calculate_covariates.R 98.87% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   93.77%   94.45%   +0.68%     
==========================================
  Files           6        6              
  Lines        2056     2182     +126     
==========================================
+ Hits         1928     2061     +133     
+ Misses        128      121       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sigmafelix sigmafelix merged commit 1a7b08a into main Feb 16, 2024
9 of 10 checks passed
@sigmafelix
Copy link
Collaborator Author

To note: @eva0marques https://github.com/Spatiotemporal-Exposures-and-Toxicology/amadeus/actions/runs/7936474332/job/21671826629?pr=13#step:6:841

dplyr::select() should be used with dplyr::all_of() or dplyr::any_of(). Please consider reflecting the syntax in future commits. Thanks!


All tests passed and failing in the Windows runner persists. I will merge this PR.

@eva0marques
Copy link
Collaborator

Yes I've seen this problem, I will try to fix it but it does not the same task than I want to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants