Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: make register button more visible and interactive to fix #106 #108

Closed
wants to merge 1 commit into from
Closed

style: make register button more visible and interactive to fix #106 #108

wants to merge 1 commit into from

Conversation

techemmy
Copy link

@techemmy techemmy commented Oct 11, 2023 •
edited
Loading

All Submissions:

fixes #106

  • Have you followed the guidelines stated in README.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.
    Made register button more visible and interactive
b. Describe your changes.
    Modified the CSS file to fix button visibility issue, added hover effect on button for more interactivity. I also increased the z-index of the button because I noticed some elements covered it while scrolling
c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).
    Closes #106

@netlify
Copy link

netlify bot commented Oct 11, 2023 •
edited
Loading

✅ Deploy Preview for nosc ready!

Name Link
🔨 Latest commit e69d5bf
🔍 Latest deploy log https://app.netlify.com/sites/nosc/deploys/65264911bd435e00083e3afd
😎 Deploy Preview https://deploy-preview-108--nosc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@techemmy techemmy closed this Oct 17, 2023
@techemmy techemmy deleted the fix-button-visibility branch October 17, 2023 11:01
@nown1ne
Copy link
Collaborator

nown1ne commented Oct 17, 2023

Awesome Work @techemmy
Sorry for the late reply we were busy with our exams
As already mentioned we require that issues are assigned to the person submitting the pr. You can always create new issues or ask for any issue to be assigned to you first
as of now you can start working on #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Register now button not visible clearly
2 participants
@techemmy @nown1ne