Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds vSHARP model and code quality changes #258

Closed
wants to merge 57 commits into from
Closed

Conversation

georgeyiasemis
Copy link
Contributor

  • vSHARP Model: Supporting both 2D and 3D. (Details: vSHARP Paper)
  • 3D Reconstruction Experiments: Various additions, such as transforms, engine changes (e.g., visualization), and the addition of new metrics and losses used in the vSHARP paper.
  • Project Organization: Introduces new project folders for vSHARP and the CMRxRecon challenge.
  • Minor Code Quality Enhancements (e.g. Enum capitalization)
  • README update

@github-actions github-actions bot added documentation Improvements or additions to documentation python labels Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: Patch coverage is 89.29032% with 83 lines in your changes are missing coverage. Please review.

Project coverage is 84.49%. Comparing base (b56a724) to head (dcdd5c3).
Report is 1 commits behind head on main.

❗ Current head dcdd5c3 differs from pull request most recent head dc69971. Consider uploading reports for the commit dc69971 to get more accurate results

Files Patch % Lines
direct/nn/mri_models.py 81.55% 19 Missing ⚠️
direct/data/mri_transforms.py 85.34% 17 Missing ⚠️
direct/functionals/hfen.py 81.08% 14 Missing ⚠️
direct/engine.py 25.00% 12 Missing ⚠️
direct/nn/vsharp/vsharp.py 92.40% 12 Missing ⚠️
direct/functionals/snr.py 87.50% 3 Missing ⚠️
direct/nn/unet/unet_3d.py 98.34% 2 Missing ⚠️
direct/nn/vsharp/vsharp_engine.py 96.92% 2 Missing ⚠️
direct/predict.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
+ Coverage   84.05%   84.49%   +0.43%     
==========================================
  Files          93       96       +3     
  Lines        6486     6964     +478     
==========================================
+ Hits         5452     5884     +432     
- Misses       1034     1080      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments

direct/data/datasets_config.py Outdated Show resolved Hide resolved
direct/data/mri_transforms.py Outdated Show resolved Hide resolved
tests/tests_functionals/test_snr.py Outdated Show resolved Hide resolved
direct/nn/unet/unet_3d.py Outdated Show resolved Hide resolved
direct/nn/vsharp/__init__.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the ci label Jan 22, 2024
@georgeyiasemis georgeyiasemis deleted the vsharp branch April 4, 2024 08:31
@georgeyiasemis georgeyiasemis restored the vsharp branch April 4, 2024 08:31
@georgeyiasemis georgeyiasemis deleted the vsharp branch April 4, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci documentation Improvements or additions to documentation python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants