Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSSL experiments #278

Merged
merged 8 commits into from
May 22, 2024
Merged

Add JSSL experiments #278

merged 8 commits into from
May 22, 2024

Conversation

georgeyiasemis
Copy link
Contributor

This PR:

  • Adds vSHARP SSL/JSSL engines
  • Configuration (.yaml) files, data split lists (.lst files) and running instructions for experiments presented in https://arxiv.org/abs/2311.15856

@georgeyiasemis georgeyiasemis self-assigned this May 20, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation python labels May 20, 2024
jonasteuwen
jonasteuwen approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@jonasteuwen jonasteuwen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure to make the CI/CD pass. Missed that during the review

@georgeyiasemis
Copy link
Contributor Author

LGTM. Make sure to make the CI/CD pass. Missed that during the review

Thanks and done @jonasteuwen ! You can now merge

@jonasteuwen jonasteuwen merged commit 575b33a into main May 22, 2024
10 checks passed
@jonasteuwen jonasteuwen deleted the feature/vsharp-ssl-jssl branch May 22, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasteuwen jonasteuwen jonasteuwen approved these changes

Assignees

@georgeyiasemis georgeyiasemis

Labels
documentation Improvements or additions to documentation python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@georgeyiasemis @jonasteuwen