Allow to overwrite mpp #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `overwrite_mpp=(mpp_x, mpp_y)` can now be added to the `SlideImage` and the `TiledROISlideImageDataset` constructors.
edwin-de-jong
previously approved these changes
Dec 29, 2022
dlup/_image.py
Outdated
|
|
||
| if self._wsi.spacing is None: | ||
| raise UnsupportedSlideError( | ||
| f"{identifier} has not parsable spacing and not explicitly set in the `overwrite_mpp` parameter." |
There was a problem hiding this comment.
Comment not entirely grammatical.
| mpp = np.array([mpp_y, mpp_x]) | ||
| self._spacings = [tuple(mpp * downsample) for downsample in self.level_downsamples] | ||
| self._spacings = [cast(tuple[float, float], tuple(mpp * downsample)) for downsample in self.level_downsamples] |
There was a problem hiding this comment.
self._spacings: I'd prefer to always add the unit of measurement in the name of any quantitative variable; e.g. self._spacings_mpp in this case. Can save a lot of headaches and difficult-to-spot bugs.
There was a problem hiding this comment.
Agreed, but in this case I don't see too much discrepancy. What other spacing would we have?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overwrite_mpp=(mpp_x, mpp_y)can now be added to theSlideImageand theTiledROISlideImageDatasetconstructors.