Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mask threshold of None #134

Merged
merged 5 commits into from
Jan 20, 2023
Merged

Allow mask threshold of None #134

merged 5 commits into from
Jan 20, 2023

Conversation

jonasteuwen
Copy link
Contributor

@jonasteuwen jonasteuwen commented Jan 19, 2023

Previously only thresholds between 0.0 and 1.0 were possible. If None everything is foreground, if 1.0 only fully annotated regions are foreground. Threshold 0.0 now means that there has to be something in the region

JorenB
JorenB previously approved these changes Jan 20, 2023
Copy link
Contributor

@JorenB JorenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This behavior seems the most natural and intuitive.

Copy link
Member

@EricMarcus-ai EricMarcus-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasteuwen jonasteuwen merged commit e92ded9 into main Jan 20, 2023
@jonasteuwen jonasteuwen deleted the mask-filter branch January 20, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants