Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/53 upgrade to bootstrap 5 #54

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Feature/53 upgrade to bootstrap 5 #54

merged 3 commits into from
Nov 7, 2022

Conversation

franciscoabenza
Copy link
Contributor

all updated :)

Still missing that navigation bar highlights active page tough it was not implemented before either

@franciscoabenza franciscoabenza linked an issue Nov 6, 2022 that may be closed by this pull request
Upgrade to bootstrap 5 #53
Closed
emilroenn
emilroenn approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@emilroenn emilroenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool

zeyus
zeyus approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@zeyus zeyus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good stuff!

I would say, just for convenience when we're working on front end stuff, we should put a screenshot of the broken thing in the issue, and the fixed version in the PR, but no big deal and it's clear what this is doing :D

@zeyus zeyus merged commit 27bbdf1 into develop Nov 7, 2022
@zeyus zeyus deleted the feature/53-upgrade-to-bootstrap-5 branch November 7, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilroenn emilroenn emilroenn approved these changes

@zeyus zeyus zeyus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to bootstrap 5
3 participants
@franciscoabenza @zeyus @emilroenn