Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/237 Resolver uses nameserver commented out in /etc/resolv.conf #238

Merged
merged 7 commits into from
May 15, 2024
Merged

Bugfix/237 Resolver uses nameserver commented out in /etc/resolv.conf #238

merged 7 commits into from
May 15, 2024

Commits on Jul 26, 2019

  1. Merge branch 'develop'

    @wtoorop
    wtoorop committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    cc967e9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop'

    @wtoorop
    wtoorop committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    4411f33 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2021

  1. Merge branch 'develop'

    @wtoorop
    wtoorop committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    182ac0a View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. Merge branch 'develop'

    @wtoorop
    wtoorop committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    48a0672 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Merge branch 'develop'

    @wtoorop
    wtoorop committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    10f98dc View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Issue #237 : Resolver uses nameserver commented out in /etc/resolv.conf 

    This /etc/resolv.conf:
    # x

    # nameserver 8.8.8.8

Still configured 8.8.8.8 as nameserver, because the comment detection in `ldns_resolver_new_frm_fp_l()` didn't anticipate empty lines before the comment.
This fix removed all comment handling from `ldns_resolver_new_frm_fp_l()`. Instead a new function is introduced `ldns_fget_token_l_resolv_conf()` that skips comments that start with '#' and ';'. The old `ldns_fget_token_l()` (that is used for zonefiles too) still accepts only ';' for comments.
    @wtoorop
    wtoorop committed May 7, 2024
    Configuration menu
    Copy the full SHA
    1acfcb2 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Move resolv.conf token parser to parse.h 

    Including a doxygen comment stating the limitations
    @wtoorop
    wtoorop committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6acd12d View commit details
    Browse the repository at this point in the history