Replace Flex+Bison based zone parser with simdzone #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcawijngaards
approved these changes
Feb 14, 2024
|
Rebased on current |
k0ekk0ek
added a commit
to k0ekk0ek/simdzone
that referenced
this pull request
Apr 11, 2024
Fixes comment by @wcawijngaards on NLnetLabs/nsd#278.
k0ekk0ek
added a commit
to NLnetLabs/simdzone
that referenced
this pull request
Apr 11, 2024
Fixes comment by @wcawijngaards on NLnetLabs/nsd#278.
|
All checks pass. I'll rebase and squash the debug commits so the PR can be merged. |
|
I've consolidated all commits. Tests are all passing, review comments have all been addressed. I think this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still some warnings to fix and of course more tests to run. I only did very minor testing yet for NSD integration, but it's a good time to start the review as it's quite a bit (I think). This PR remove the Bison+Flex based zone parser from NSD and replaces it with simdzone.
Please note that both these changes and the current
mainbranch of simdzone require review. This is also a good time to figure out how to best manage sub modules in the NSD repository. I now just did it commit based on the latest commit in master, we probably want to change that?