Proxy protocol #281
Merged
Proxy protocol #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c and proxy_protocol.h.
…address. Fix for printout of refusal in log.
k0ekk0ek
approved these changes
May 31, 2023
|
Hi, |
|
Hi @pettai, it's waiting for one more review to complete. Expect this to be merged soon. |
|
I noted an issue #297 then merging this branch to the latest git version of NSD, so apart from the review, this also needs to be fixed before merging. Thx |
…r_remaining(data->query->packet) > 0' failed.
|
The commit dfcdadb fixes the issue. The buffer was not reset properly between queries, the commit fixes that. |
- more generic switch statement for address families; - comment the protocol values as such in their definitions; - less hardcoded values for address family and protocol combinations.
wcawijngaards
added a commit
that referenced
this pull request
Oct 3, 2023
- Merge #281: Proxy protocol. An implementation of PROXYv2 for NSD. It can be configured with proxy-protocol-port: portnum with the port number of the interface on which proxy traffic is handled. The interface can support proxy traffic for UDP, TCP and TLS.
|
So it has been done 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of PROXYv2 for NSD.
It can be configured with
proxy-protocol-port: <portnum>with the port number of the interface on which proxy traffic is handled. The interface can support proxy traffic for UDP, TCP and TLS.It uses code from Unbound, that implements the proxy protocol specs, in NLnetLabs/unbound#881 .