-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- Reduce unnecessary linking #511
Conversation
At the same time, there is overlinking happening there:
EDIT: The usual |
Many thanks for testing! I looked into it, and found two issues:
Here /cc @orbea Mind to test this patch on Gentoo with |
This patch seems to compile correctly using slibtool, the current git head (dd25413) and I think the only way this could fail with slibtool is if |
Thanks a lot for testing and clear explanations! |
- Link to libpython only when needed, fixes #242 When pyunbound is enabled while pythonmodule is not (i.e., ./configure --without-pythonmodule --with-pyunbound), only the Python library _unbound.so uses Python functions, and main programs (unbound, unbound-anchor, ...) and libunbound.so do not. This patch removes unneeded linking. - Link the Python library _unbound.so to Python only. _unbound.so does not directly use libraries used by libunbound. This patch removes unneeded linking mentioned in [1] [1] #511 (comment)
Rebased to resolve conflicts after 8e538dc |
Thanks for this! LGTM and the Python tests pass. |
- Merge PR #511 from yan12125: Reduce unnecessary linking.
* nlnet/master: (36 commits) - Add missing configure flags for optional features in the documentation. - Fix Unbound capitalization in the documentation. - Fix to pick up other class local zone information before unlock. - Allow local-data for classes other than IN to inherit a configured local-zone's type if possible, instead of defaulting to type transparent as per the implicit rule. - Add code similar to fix for ldns for tab between strings, for consistency, the test case was not broken. Continue with version 1.14.1 - Fix validator debug output about DS support, print correct algorithm. Changelog note for NLnetLabs#581 Fix -Wshadow Fix -Wmissing-prototypes by declaring functions static. - Fix compile warning for if_nametoindex on windows 64bit. - Fix doc/unbound.doxygen to remove obsolete tag warning. - configure is set to 1.14.0, and release branch. - Fix NLnetLabs#574: Review fixes for size allocation. - Fix NLnetLabs#454: listen_dnsport.c:825: error: ‘IPV6_TCLASS’ undeclared. Changelog note for NLnetLabs#530: - Merge PR NLnetLabs#530 from Shchelk: Fix: dereferencing a null pointer. Changelog note for NLnetLabs#522: - Merge PR NLnetLabs#522 from sibeream: memory management violations fixed. Changelog note for NLnetLabs#562: - Merge PR NLnetLabs#562 from Willem: Reset keepalive per new tcp session. Changelog note for NLnetLabs#555: - Merge PR NLnetLabs#555 from fobser: Allow interface names as scope-id in IPv6 link-local addresses. Changelog note for NLnetLabs#493: - Merge PR NLnetLabs#493 from Jaap: Fix generation of libunbound.pc. Changelog note for NLnetLabs#511: - Merge PR NLnetLabs#511 from yan12125: Reduce unnecessary linking. ...
When pyunbound is enabled while pythonmodule is not (i.e.,
./configure --without-pythonmodule --with-pyunbound
), only the Python library_unbound.so
uses Python functions, and main programs (unbound
,unbound-anchor
, ...) andlibunbound.so
do not. This patch removes unneeded linking.Note that I didn't commit re-generated autoconf files as that brings too many unrelated changes to
./configure
. If you wish, I will push updated autoconf files.