Skip to content

Fast Reload Option#1042

Merged
wcawijngaards merged 165 commits into
masterfrom
fast-reload-option
Mar 31, 2025
Merged

Fast Reload Option#1042
wcawijngaards merged 165 commits into
masterfrom
fast-reload-option

Conversation

@wcawijngaards

Copy link
Copy Markdown
Member

The branch continues the fast-reload work, and adds more config options to fast-reload. This is a good idea, since otherwise, old references cause trouble, that would have to be resolved in another manner if more config options are not supported by reloading them.

…tes and

  can continue byte by byte. Also it can continue after an interrupt.
  forward_add and forward_delete should be distributed to other processes,
  but when threaded, they should not be distributed to other threads because
  the structure is not thread specific any more.
@wcawijngaards wcawijngaards requested a review from gthess July 24, 2024 14:18
@gthess gthess added this to the 1.23.0 milestone Mar 19, 2025
* - fast-reload review, respip set can be null from a view.

* - fast-reload review, typos.

* - fast-reload review, keep clang static analyzer happy.

* - fast-reload review, don't forget to copy tag_actions.

* - fast-reload review, less indentation.

* - fast-reload review, don't leak respip_actions when reloading.

* - fast-reload review, protect NULL pointer dereference in get_mem
  functions.

* - fast-reload review, add fast_reload_most_options.tdir to test most
  options with high verbosity when fast reloading.

* - fast-reload review, don't skip new line on long error printouts.

* - fast-reload review, typo.

* - fast-reload review, use new_z for consistency.

* - fast-reload review, nit for unlock ordering to make eye comparison
  with the lock counterpart easier.

* - fast-reload review, in case of error the sockets are already closed.

* - fast-reload review, identation.

* - fast-reload review, add static keywords.

* - fast-reload review, update unbound-control usage text.

* - fast-reload review, updates to the man page.

@gthess gthess left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
My review comments were part of #1259 which are already addressed here.
When conflicts are resolved, a squash commit should land this feature into master and onto the next release 👍

- Merge #1042: Fast Reload. The unbound-control fast_reload is added.
  It reads changed config in a thread, then only briefly pauses the
  service threads, that keep running. DNS service is only interrupted
  briefly, less than a second.
@wcawijngaards wcawijngaards merged commit 218f5cf into master Mar 31, 2025
@gthess gthess deleted the fast-reload-option branch September 15, 2025 11:35
@gthess gthess mentioned this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

3 participants