Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #887 (Timeouts to forward servers on BSD based system w… #894

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Fix for issue #887 (Timeouts to forward servers on BSD based system w… #894

merged 1 commit into from
Jun 15, 2023

Conversation

Philip-NLnetLabs
Copy link
Member

…ith ASLR)

and proabbly #516 (Stream reuse does not work on Windows)

@Philip-NLnetLabs
Fix for issue #887 (Timeouts to forward servers on BSD based system w…
52581f8 
…ith ASLR)

and proabbly #516 (Stream reuse does not work on Windows)
wcawijngaards
wcawijngaards approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fixes look sensible. They are both checks for a return of the element that is just before, and thus smaller than, the key value that is looked for. Good to fix the code for it!

@Philip-NLnetLabs Philip-NLnetLabs merged commit b1bcde3 into master Jun 15, 2023
@gthess gthess deleted the freebsd-aslr-issue branch July 9, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcawijngaards wcawijngaards wcawijngaards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Philip-NLnetLabs @emaste @wcawijngaards @gthess