Set Elmah source and user #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will add two options: - LoggerNameAsSource will set the loggers name as source - IdentityNameAsUser will set the identity user as user
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
=======================================
- Coverage 85.71% 80% -5.72%
=======================================
Files 1 1
Lines 21 30 +9
Branches 6 12 +6
=======================================
+ Hits 18 24 +6
Misses 2 2
- Partials 1 4 +3
Continue to review full report at Codecov.
|
|
I;m sorry for the delay on this |
snakefoot
reviewed
Mar 30, 2020
NLog.Elmah/ElmahTarget.cs
Outdated
| /// <summary> | ||
| /// Use <see cref="LogEventInfo.LoggerName"/> as source if <see cref="LogEventInfo.Exception"/> is <c>null</c>. | ||
| /// </summary> | ||
| public bool LoggerNameAsSource { get; set; } |
There was a problem hiding this comment.
Why not make it a Layout that is initially assigned to ${exception:format=Source:whenEmpty=${logger}} ? (Requires dependency update to NLog 4.6.7)
Bumps [NLog](https://github.com/NLog/NLog) from 4.0.1 to 4.6.7. - [Release notes](https://github.com/NLog/NLog/releases) - [Changelog](https://github.com/NLog/NLog/blob/v4.6.7/CHANGELOG.md) - [Commits](NLog/NLog@4.0.1...v4.6.7) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
|
Thanks a lot! |
|
https://www.nuget.org/packages/NLog.ELMAH ver. 4.1 has been released (Changed setting name "Source" to "LogSource") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add two options:
We wanted to be able to set source and user to the Elmah table, so wie added these two options. Seems related to #7.