Added AspNet-Request-ConnectionId and AspNet-Response-Has-Started

[bakgerman]

Added render for (Core only) HttpContext.Connection.Id
Added render for both Core and Framework for HttpResponse HeadersWritten(Framework) and HasStarted(Core) named AspNetResponseHeadersWrittenLayoutRenderer
Added public bool Verbose option for ClientCertificate renderer
Added extension methods for HttpContext for TryGetConnection and TryGetWebSocket

[snakefoot]

Though it seems tempting, then you cannot repair past mistakes unless doing a major-version-bump (Ex. NLog.Web v6)

Please revert class-renames, then we can make an issue about fixing this with v6.

[bakgerman]

Yes I will revert the class names commits and keep them local.

[bakgerman]

Though it seems tempting, then you cannot repair past mistakes unless doing a major-version-bump (Ex. NLog.Web v6)

Please revert class-renames, then we can make an issue about fixing this with v6.

reverted as requested, kept changes local to my laptop

[codecov-commenter]

Codecov Report

Merging #796 (c93f694) into master (0b1f2a8) will increase coverage by 2%.
The diff coverage is 82%.

❗ Current head c93f694 differs from pull request most recent head 99b7342. Consider uploading reports for the commit 99b7342 to get more accurate results

@@          Coverage Diff           @@
##           master   #796    +/-   ##
======================================
+ Coverage      67%    69%    +2%     
======================================
  Files          60     62     +2     
  Lines        1011   1141   +130     
  Branches      249    284    +35     
======================================
+ Hits          680    787   +107     
- Misses        225    236    +11     
- Partials      106    118    +12     

Impacted Files	Coverage Δ
src/Shared/Internal/HttpContextExtensions.cs	61% <ø> (+7%)	⬆️
...enderers/AspNetRequestIsWebSocketLayoutRenderer.cs	100% <ø> (ø)
...outRenderers/AspNetRequestLocalIpLayoutRenderer.cs	67% <ø> (ø)
...tRenderers/AspNetRequestLocalPortLayoutRenderer.cs	67% <ø> (ø)
...Renderers/AspNetRequestRemotePortLayoutRenderer.cs	67% <ø> (ø)
...equestWebSocketRequestedProtocolsLayoutRenderer.cs	78% <ø> (ø)
...rs/AspNetRequestClientCertificateLayoutRenderer.cs	57% <50%> (+7%)	⬆️
...d/LayoutRenderers/AspNetUserClaimLayoutRenderer.cs	62% <83%> (ø)
...rers/AspNetResponseHeadersWrittenLayoutRenderer.cs	100% <100%> (ø)
...utRenderers/AspNetRequestDurationLayoutRenderer.cs	56% <0%> (-9%)	⬇️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c5e983...99b7342. Read the comment docs.

[bakgerman]

w3c layout unit test fail again, but this should be able to be pulled successfully.

[bakgerman]

After this I cannot think of more NLog.Web layout renderers. Hopefully someone will find them useful. We are not trying to be equal to Visual Studio debugger in NLog, but I just try to find properties of HttpContext that we did not have already, that might be necessary to be logged.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

88.5% Coverage
0.0% Duplication

[snakefoot]

Added wiki-pages:

https://github.com/NLog/NLog/wiki/AspNet-Response-HasStarted-Layout-Renderer
https://github.com/NLog/NLog/wiki/AspNet-Request-ConnectionId-Layout-Renderer

[snakefoot]

w3c layout unit test fail again, but this should be able to be pulled successfully.

Thank you for nudging. Have tried to make W3CLoggerLayoutTests more stable, by replacing finalizer with dispose and forced AccurateUtcTimeSource

[snakefoot]

Have now merged #813 that will ensure future class-names will always end with "LayoutRenderer" (And matches their type-alias)